Replace deprecated hiltViewModel#6118
Merged
TimoPtr merged 1 commit intofeature/use_new_onboardingfrom Dec 3, 2025
Merged
Conversation
jpelgrom
approved these changes
Dec 1, 2025
Member
|
Do all these PRs need to merge into feature/use_new_onboarding? That branch is becoming quite big. |
Member
Author
This or we merge the use_new_onboarding on main then all of these other branches. |
Member
That depends on your confidence :) But some of these changes, like this PR and part of the string cleanup, don't really need feature/use_new_onboarding. |
Member
Author
|
Sorry I commented on the wrong PR yes it was possible to do this PR on main... Having it here is going to make my life easier. (This comment was for the strings PR) |
TimoPtr
added a commit
that referenced
this pull request
Dec 17, 2025
* Remove LaunchActivity * Merge onboarding and app * Update lint baselines * Add battery optimization permission to onboarding (#6095) * Request battery optimization permission when leaving Location screen * Fix crash on Android 6 with Github icon * Replace deprecated hiltViewModel (#6118) * Add notification permission bottom sheet (#6094) * Store user preference for Notification dialog * Add notification bottom sheet on the webview activity * Remove strings that are not used anymore (#6117) --------- Co-authored-by: Joris Pelgröm <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hiltViewModelextension has been moved to another package this PR use the new one.Checklist